Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf: use a redis cluster #596

Merged
merged 21 commits into from
Jan 12, 2025
Merged

perf: use a redis cluster #596

merged 21 commits into from
Jan 12, 2025

Conversation

MartinKolarik
Copy link
Member

@MartinKolarik MartinKolarik commented Jan 6, 2025 •
edited
Loading

  • 10 redis processes in total (persistent, non-persistent, 8 in a cluster for measurements) as the cluster itself can only have 1 DB
  • key structure updated so that keys for a single measurement are always in the same shard (required for Lua scripts)
  • the default docker compose file is now used for setting up the production redis, there's a new one for dev

@MartinKolarik MartinKolarik force-pushed the redis-cluster branch 2 times, most recently from 1fc5cf0 to be0968b Compare January 6, 2025 20:04
@MartinKolarik MartinKolarik force-pushed the redis-cluster branch 4 times, most recently from 5f04f63 to 0c8d273 Compare January 6, 2025 20:38
@MartinKolarik MartinKolarik marked this pull request as ready for review January 8, 2025 15:01
alexey-yarmosh
alexey-yarmosh previously requested changes Jan 9, 2025
View reviewed changes
Copy link
Member

@alexey-yarmosh alexey-yarmosh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Big job done 💪

test/e2e/setup.ts Outdated Show resolved Hide resolved
docker-compose.dev.yml Outdated Show resolved Hide resolved
docker-compose.dev.yml Show resolved Hide resolved
@MartinKolarik MartinKolarik merged commit 66a4b48 into master Jan 12, 2025
5 checks passed
@MartinKolarik MartinKolarik deleted the redis-cluster branch January 12, 2025 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexey-yarmosh alexey-yarmosh Awaiting requested review from alexey-yarmosh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MartinKolarik @alexey-yarmosh